[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Making the rating painter class public
From:       Frank Osterfeld <frank.osterfeld () gmx ! de>
Date:       2008-02-25 22:12:00
Message-ID: 200802252312.06093.frank.osterfeld () gmx ! de
[Download RAW message or body]


On Monday 25 February 2008, Sebastian Trüg wrote:


>        void draw( QPainter* painter, const QRect& rect, int rating, int 
hoverRating = -1 );

I don't get what hoverRating means here from reading the header, so 
documentation wouldn't hurt.

>             /**
>               * Calculate the rating value from mouse position pos.
>               *
>               * \return The rating corresponding to pos or -1 if pos is
>               * outside of the configured rect.
>               */
>             int fromPosition( const QRect& rect, const QPoint& pos );

That should be const I think - (and isn't int ratingFromPosition() const more 
clear? This is a RatingPainter, not a Rating after all).

Frank


[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]