[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: [PATCH] Qt 4.4 - Fix alien widgets in Dolphin
From: David Faure <faure () kde ! org>
Date: 2008-02-18 9:31:06
Message-ID: 200802181031.06528.faure () kde ! org
[Download RAW message or body]
On Sunday 17 February 2008, Robert Knight wrote:
> Hi David,
>
> The attached patch attempts to fix this inside KIO by taking the top
> level window associated with the passed widget in
> JobUiDelegate::setWindow().
>
> The patch does change the semantics of the API slightly since it
> becomes possible that JobUiDelegate::window() does not return the same
> value passed to JobUiDelegate::setWindow().
Right. Fixable with documentation, as you did. One has always been supposed
to pass a toplevel window to that method, but it didn't matter in the past.
> QWidget does provide an alternative, effectiveWinId() which goes up
> the widget chain and finds the first widget that does have an X11
> window associated with it and returns the id of that. The setWindow()
> change is simpler since it only occurs in one place.
The 4 patches seem fine to me.
--
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic