[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: KColorCells fails on resizing rows/columns
From: "=?ISO-8859-1?Q?Percy_Camilo_Trive=F1o_Aucahuasi?=" <orgyforever () gmail ! com>
Date: 2008-02-14 3:02:18
Message-ID: 579229230802131902k72c6590bi8334c303ea3aa256 () mail ! gmail ! com
[Download RAW message or body]
>Patch is starting to look good.
Thanks ; )
>The kdelibs coding style is more "brace on the same line" than "brace on
its own line", >though, so
In fact the original file doesn't had a good coding style ... any way you're
right, I had to use "astyle" and now the patch contain the changes to
KColorCells plus a coding style acoring to kdelib policies ;).
Thanks for all the help and tips ; ).
The commit is done now.
Greetings
2008/2/13, David Faure <faure@kde.org>:
>
> On Tuesday 12 February 2008, you wrote:
> > >Good. Can we see the new patch? ;-)
> >
> > Hello David, sorry I forgot attach the new one : ).
> >
> > Also I removed the the member "acceptDrags" of KColorCellsPrivate,
> becouse
> > QAbstractItemView has a property called "dragEnabled", so the method
> > KColorCells::setAcceptDrags does a call to
> > QAbstractItemView::setDragEnabled. I don't remove the public method
> > KColorCells::setAcceptDrags but I think that in the future this method
> has
> > to removed.
>
> Patch is starting to look good.
>
> The kdelibs coding style is more "brace on the same line" than "brace on
> its own line", though, so
>
> - if ( tableItem == 0 ) {
> + if ( tableItem == 0 )
> + {
>
> should be reverted.
>
> + QTableWidgetItem * tableItem =
> itemAt(event->pos());
> using tabs? Please make it 4 spaces.
>
> Once the coding style is unified, feel free to commit.
>
> --
> David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
> Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org
> ).
>
[Attachment #3 (text/html)]
>Patch is starting to look good.<br>Thanks ; )<br><br>>The kdelibs \
coding style is more "brace on the same line" than "brace on \
its own line", >though, so<br><br>In fact the original file \
doesn't had a good coding style ... any way you're right, I had to \
use "astyle" and now the patch contain the changes to KColorCells \
plus a coding style acoring to kdelib policies ;).<br> <br>Thanks for all \
the help and tips ; ). <br><br>The commit is done \
now.<br><br>Greetings<br><br><div><span class="gmail_quote">2008/2/13, \
David Faure <<a href="mailto:faure@kde.org">faure@kde.org</a>>:</span><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); \
margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> On Tuesday 12 February \
2008, you wrote:<br>> >Good. Can we see the new patch? \
;-)<br>><br>> Hello David, sorry I forgot attach the new one : \
).<br>><br>> Also I removed the the member "acceptDrags" of \
KColorCellsPrivate, becouse<br> > QAbstractItemView has a property \
called "dragEnabled", so the method<br>> \
KColorCells::setAcceptDrags does a call to<br>> \
QAbstractItemView::setDragEnabled. I don't remove the public \
method<br>> KColorCells::setAcceptDrags but I think that in the future \
this method has<br> > to removed.<br><br>Patch is starting to look \
good.<br><br>The kdelibs coding style is more "brace on the same \
line" than "brace on its own line", though, \
so<br><br>- if ( tableItem == 0 ) {<br> \
+ if ( tableItem == 0 \
)<br>+ \
{<br><br>should be reverted.<br><br>+ &nb \
sp; & \
nbsp; \
QTableWidgetItem * tableItem = itemAt(event->pos());<br>using tabs? \
Please make it 4 spaces.<br> <br>Once the coding style is unified, feel \
free to commit.<br><br>--<br>David Faure, <a \
href="mailto:faure@kde.org">faure@kde.org</a>, sponsored by Trolltech to \
work on KDE,<br>Konqueror (<a \
href="http://www.konqueror.org">http://www.konqueror.org</a>), and KOffice \
(<a href="http://www.koffice.org">http://www.koffice.org</a>).<br> \
</blockquote></div><br>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic