[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Debug warnings for broken icons
From:       David Faure <faure () kde ! org>
Date:       2008-02-12 18:08:13
Message-ID: 200802121908.13550.faure () kde ! org
[Download RAW message or body]

On Wednesday 19 December 2007, Urs Wolfer wrote:
> For the moment, I prefer the way to not cache broken 
> icons. This makes it way easier to find and fix such icons. Of course it 
> would be nice if we have a #define when we compile kdelibs in debug mode (is 
> that possible?). Then we could just not insert it into the cache when we are 
> in debug mode.

Actually we should never insert unknown icons into the cache, otherwise we cannot
honour the "canReturnNull=true" argument of loadIcon().... I'm in the process
of fixing this [and writing related unit tests].

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]