[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] strigi (trunk) fixes for msvc
From:       "Jos van den Oever" <jvdoever () gmail ! com>
Date:       2008-02-01 22:22:10
Message-ID: c2dbc4260802011422o4405f4f1pf4d1389b9cb2311a () mail ! gmail ! com
[Download RAW message or body]

2008/2/1, Christian Ehrlicher <Ch.Ehrlicher@gmx.de>:
> I did not run any unit tests because it was no functional change and the
> setenv() - code is imho also used in kdefakes.

I did not mean you should run them to verify your patch (though you
should ;-) but to see if they run nicely at all. I've no idea how the
tests perform on windows with microsoft nor mingw nor g++ compiler.

Just trying a 'make test' and pasting the results here would be quite
interesting already.

Cheers,
Jos
[prev in list] [next in list] [prev in thread] [next in thread]