[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [PATCH] Stupid sorkaround for bug in kde3support
From:       Sebastian =?iso-8859-1?q?Tr=FCg?= <strueg () mandriva ! com>
Date:       2008-01-23 16:04:24
Message-ID: 200801231704.24355.strueg () mandriva ! com
[Download RAW message or body]

Hello,

there seems to be a bug in K3ProcessController in kde3support. The ref 
counting is somehow broken. Now I don't have the insight to properly fix it 
ATM so I just disabled the deletion of the singleton.

May I commit or is kde3support important enough to find a "real" fix?

And while I am at it: There seems to be no way to get ones hands on the stdout 
and stdin fds in QProcess like one could in K3Process. Is that correct?

Cheers,
Sebastian

["k3process.diff" (text/x-diff)]

Index: kdecore/k3processcontroller.cpp
===================================================================
--- kdecore/k3processcontroller.cpp	(revision 765209)
+++ kdecore/k3processcontroller.cpp	(working copy)
@@ -72,12 +72,16 @@
 
 void K3ProcessController::deref()
 {
+    // trueg: the ref handling is broken. I don't understand the code enough to fix it and doubt the
+    // saved memory in kde3support is worth the time to search for the bug.
+#if 0
     Private::refCount--;
     if( !Private::refCount ) {
         resetHandlers();
         delete Private::instance;
         Private::instance = 0;
     }
+#endif
 }
 
 K3ProcessController* K3ProcessController::instance()


[prev in list] [next in list] [prev in thread] [next in thread]