[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdebug vs. non-debug builds
From:       "Jaison Lee" <lee.jaison () gmail ! com>
Date:       2007-12-23 5:21:45
Message-ID: 2d720bd30712222121l134ec397oa9248771d33268bc () mail ! gmail ! com
[Download RAW message or body]


> > #if !defined(KDE_NO_DEBUG_OUTPUT)
> > # define kDebug        KDebug(QtDebugMsg, __FILE__, __LINE__, # Q_FUNC_INFO)
> > #else
> > # define kDebug        if (1); else kDebug
> > #endif
> >
> > this can be properly solved by inlining kDebugDevNull() to return a
> > fully inline KNoDebugStream like it was in kde3 and how QDebug does.
> >
> uhm, actually, this won't help, as the return value cannot be assigned
> to QDebug then; QDebug itself has the same problem. so unless somebody
> has a brilliant idea ...

I'm not certain of its brilliance, but I did notice that the offending
definition is actually a redefinition of kDebug and kWarning from
further up in the same file. Simply commenting out the faulty
definitions has so far seemed successful. The attached patch
demonstrates what I'm talking about.

I'm running a full recompile of kdebase right now but it takes too
long on my machine and I'm going to bed right now. :) If this works
I'll commit in the morning. There may be a better fix but right now
getting things to compile seems most important.

["fix_release_mode.patch" (application/octet-stream)]

[prev in list] [next in list] [prev in thread] [next in thread]