[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Fixes meinproc/docbook can't handle paths with spaces
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2007-12-20 21:42:24
Message-ID: 200712202242.24968.neundorf () kde ! org
[Download RAW message or body]

On Wednesday 19 December 2007, Ingo Klöcker wrote:
> On Tuesday 18 December 2007, Alexander Neundorf wrote:
> > On Tuesday 18 December 2007, Ingo Klöcker wrote:
> > > FWIW, below you'll find the function that parses the result of
> > > getenv("SGML_CATALOG_FILES"). The code is pretty straightforward
> > > and it's obvious that nobody thought about spaces in a catalog's
> > > path.
> >
> > Can you file a bug report for libxml ?
>
> Instead of doing this I have converted the SGML catalogs in kdoctools to
> XML catalogs and made meinproc write the catalog paths (encoded as file
> URLs) to the environment variable XML_CATALOG_FILES.
>
> Now kdelibs builds even if the source dir contains spaces.
>
> Is it okay to commit this patch and to svn add the new XML catalogs (see
> attached tar ball)?

I can't comment on that.
IMO it is a bug fix, not a feature.

Alex
[prev in list] [next in list] [prev in thread] [next in thread]