[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KHistoryComboBox --- make konq's location box not fail
From:       "Maksim Orlovich" <mo85 () cornell ! edu>
Date:       2007-12-17 23:50:16
Message-ID: 14352.24.58.159.73.1197935416.squirrel () webmail ! cornell ! edu
[Download RAW message or body]

> On Friday 14 December 2007 19:32:59 Maksim Orlovich wrote:
>> Hi...  We currently have a critical bug in trunk where konqueror's combo
>> does not work half the time (#153568). The reason is that we rely on the
>> activated() signal from QComboBox as the enter trigger. However, this
>> signal does not get emitted all the time --- there is a workaround to
>> simulate it when the combo is in NoInsert mode already --- but
>> QComboBox::Private::_q_returnPressed() might also not emit it if the box
>> is full. The attached extends the emulation. I would appreciate review
>> of
>> that, particularly since I am a bit concerned by the whole
>> emulation-of-signal thing...
>
> Maksim, did you commit this one?

Yep, today


[prev in list] [next in list] [prev in thread] [next in thread]