[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: [PATCH] KProcess port of khelpcenter
From: Oswald Buddenhagen <ossi () kde ! org>
Date: 2007-12-17 23:10:39
Message-ID: 20071217231039.GA29257 () ugly ! local
[Download RAW message or body]
On Tue, Dec 18, 2007 at 12:05:28AM +0100, Ralf Habacker wrote:
> Any more issues becore I can commit it
>
remove the qDebugs and make the kDebugs kWarnings.
> Index: toc.cpp
> ===================================================================
> --- toc.cpp (revision 749421)
> +++ toc.cpp (working copy)
> @@ -156,15 +186,15 @@
> delete meinproc;
>
> QFile f( m_cacheFile );
> - if ( !f.open( QIODevice::ReadWrite ) )
> + if ( !f.open( QIODevice::ReadWrite ) )
> return;
>
> QDomDocument doc;
> if ( !doc.setContent( &f ) )
> - return;
> + return;
>
> QDomComment timestamp = doc.createComment( QString::number( sourceFileCTime() ) );
> - doc.documentElement().appendChild( timestamp );
> + doc.documentElement().appendChild( timestamp );
>
all three are bogus space insertions. twitching thumb? :-D
rest looks fine.
--
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Confusion, chaos, panic - my work here is done.
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic