From kde-core-devel Mon Dec 17 22:53:49 2007 From: Sebastian Kuegler Date: Mon, 17 Dec 2007 22:53:49 +0000 To: kde-core-devel Subject: Re: [PATCH] KHistoryComboBox --- make konq's location box not fail Message-Id: <200712172353.49718.sebas () kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=119793204923802 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart2287247.9jN8nL6aLh" --nextPart2287247.9jN8nL6aLh Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 14 December 2007 19:32:59 Maksim Orlovich wrote: > Hi... We currently have a critical bug in trunk where konqueror's combo > does not work half the time (#153568). The reason is that we rely on the > activated() signal from QComboBox as the enter trigger. However, this > signal does not get emitted all the time --- there is a workaround to > simulate it when the combo is in NoInsert mode already --- but > QComboBox::Private::_q_returnPressed() might also not emit it if the box > is full. The attached extends the emulation. I would appreciate review of > that, particularly since I am a bit concerned by the whole > emulation-of-signal thing... Maksim, did you commit this one? =2D-=20 sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9=20 --nextPart2287247.9jN8nL6aLh Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQEVAwUAR2b9/WdNh9WRGQ75AQISMwgAofPPlLjBjeN3683igbkdvSAilcZ13t62 F4ieVJUKD/FTsWaWFyGpmm+FwnLIuXP1YgTdv1oHOU6R85cfDPXDHhiKee3Ah/uU Bl93q78uKRCOfatljfd+/AUuVV6woWG3bLhNCmn2MSqCNaOeQ+tg3+EjpChtoqde pMJF9EOA4vrVJfQAu92uSFrdEq8TMW7br73Rid2bPuheEpZaWnON2gkHow5SRpvw BbeS1+xG6YjVsVA2+m5UgWDAF3Ap5G6MZaNgJXG/q/08jTxvoTAQyWYggRjbgJ2V HdcAqo/9DbUtyemjHSuo9tYFw814d9u6mctZ0LgBKUkqD0D15qSuWw== =YdXw -----END PGP SIGNATURE----- --nextPart2287247.9jN8nL6aLh--