[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    requesting exception to message freeze
From:       Germain Garand <germain () ebooksfrance ! org>
Date:       2007-12-09 0:49:42
Message-ID: 200712090149.42520.germain () ebooksfrance ! org
[Download RAW message or body]

Hi,
I noticed that during porting of some xmlgui magic, a string was forgotten in 
the KHTML KPart that gives an unfortunate effect.

Namely, when right-clicking an iframe, 
a popup menu should appear as follow:

   Open with         >
   Preview in Advanced Text Editor
   Frame             >
   Stop Animations

Instead it appears as:

   Open with         >
   Preview in Advanced Text Editor
                     >
   Stop Animations

with an unhelpful blank entry in place of "Frame".

Would it be acceptable to apply the attached patch?

Greetings,
Germain

["patch" (text/x-diff)]

diff --git a/khtml/khtml_ext.cpp b/khtml/khtml_ext.cpp
index d56dabf..cfac4e2 100644
--- a/khtml/khtml_ext.cpp
+++ b/khtml/khtml_ext.cpp
@@ -560,7 +560,7 @@ KHTMLPopupGUIClient::KHTMLPopupGUIClient( KHTMLPart *khtml, const KUrl &url )
     // frameset? -> add "Reload Frame" etc.
     if (!hasSelection) {
         if ( khtml->parentPart() ) {
-            KActionMenu* menu = new KActionMenu(this);
+            KActionMenu* menu = new KActionMenu( i18n( "Frame" ), this);
             KAction *action = new KAction( i18n( "Open in New &Window" ), this );
             d->m_actionCollection->addAction( "frameinwindow", action );
             action->setIcon( KIcon( "window-new" ) );


[prev in list] [next in list] [prev in thread] [next in thread]