This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig343872E368C0B0E567EFDF66
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Kevin Krammer schrieb:
> On Sunday 02 December 2007, Andreas Pakulat wrote:
>> On 02.12.07 22:26:14, Christian Ehrlicher wrote:
>>> Hi,
>>>
>>> due to a missing copy operator I get a crash (on windows) when konque=
ror
>>> tries to display historyPopupCompletionItems.
>>> It happens because msvc (don't know if/how this works with gcc) creat=
es
>>> a default copy ctor which does not copy the d-ptr correctly -> double=

>>> free d-ptr -> crash.
>>>
>>> Afaics therer are also other classes which have d-ptr but no copy cto=
r
>>> (at least KCompletionBase and KCompletion).
>> KCompletion can't be copied (its a QObject subclass) and as far as I c=
an
>> see KCompletionBase is not used as value type thus no need for a copy
>> constructor or assignment operator.
>=20
> I'd say whenever a class has a pointer member, it should either have=20
> Q_DISABLE_COPY or copy constructor and assignment operator.
>=20
I found some more where the copy ctor/Q_DISABLE_COPY seems missing:

kdeui/util/kwordwrap.h
kdeui/util/kxerrorhandler.h
kdecore/compression/kfilterbase.h
kdecore/date/*.h
kdecore/localization/kcharsets.h ?
kwallet/backend/kwalletbackend.h

But I don't know how a krazy check can find this problems.

Christian



--------------enig343872E368C0B0E567EFDF66
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHVDSZHAIuqbOiZ+kRAq0XAJ42vR+JQQqBaveE+s73ExdIiF+xawCfTnMs
yfAac9CyouvWST6OTG6Bxps=
=dfAY
-----END PGP SIGNATURE-----

--------------enig343872E368C0B0E567EFDF66--