[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Fix overridden virtual method in KTimeZone classes
From:       Michael Pyne <michael.pyne () kdemail ! net>
Date:       2007-11-30 21:26:53
Message-ID: 200711301626.55981.michael.pyne () kdemail ! net
[Download RAW message or body]


On Friday 30 November 2007, David Jarvie wrote:
> Thanks to the -Woverloaded-virtual option, I've discovered that the virtual
> method KTimeZoneSource::parse() isn't reimplemented in ICalTimeZoneSource,
> and because it isn't applicable to ICalTimeZoneSource, the way
> KTimeZone::parse() and KTimeZone::data() operate could easily produce loss
> of data or a crash. The attached BIC patch will allow ICalTimeZone (and any
> other derived classes with similar characteristics) to be fixed. I don't
> see any way to fix it without changing the API.

Is this really BIC?

I could be missing something but I see no header changes that would make it 
BIC.

Regards,
 - Michael Pyne

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]