[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: getting rid of unneccessary test for <default>
From:       "Thomas Braxton" <kde.braxton () gmail ! com>
Date:       2007-11-23 4:21:00
Message-ID: 928c3f1b0711222021n2c6dbaedw504de749bdf955e6 () mail ! gmail ! com
[Download RAW message or body]

On 11/22/07, Oswald Buddenhagen <ossi@kde.org> wrote:
> On Thu, Nov 22, 2007 at 05:16:40PM -0600, Thomas Braxton wrote:
> > While trying to remove <default> as the default group name in KConfig,
> >
> ugh, you're still pursuing this at this point? well, *i* won't object
> ... i'm even all for it. :=)
>
> > OK to commit?
> >
> i'm not too happy about the test case being in the setup function. move
> it to the bottom of testSimple().
> fwiw, i'd commit the testcase first, then the "redundancy removers".

that was the plan :)
committed r740359 & r740360
[prev in list] [next in list] [prev in thread] [next in thread]