[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdelibs/kdeui/paged
From:       David Faure <faure () kde ! org>
Date:       2007-11-22 19:18:29
Message-ID: 200711222018.29314.faure () kde ! org
[Download RAW message or body]

On Tuesday 20 November 2007, Sebastian Sauer wrote:
> Hi *
> 
> atm it is not possible to disable aka hide the header within a 
> KPageView/KPageWidget if the faceType != Tabbed. Following both patches to 
> fix this;
> 
> 1. the header uses the name if QString::null and if "" the header does not got 
> displayed. While this seems ugly it should provide the less offensive way to 
> fix it since places where it's used atm without defining the header will 
> still work as before and only an explicit setHeader("") does disable aka hide 
> the header.
> 
> 2. the alternate would be the following patch. Headers are just never 
> displayed since setHeader() is explicit called. This looks like the most 
> correct (as in logical) solution but may break (as in the header does not got 
> shown any longer while it was before) now for those apps that didn't defined 
> the header explicit.

Wouldn't be cleaner to just add a hideHeader() method?

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]