From kde-core-devel  Thu Nov 22 15:30:26 2007
From: Michael Pyne <michael.pyne () kdemail ! net>
Date: Thu, 22 Nov 2007 15:30:26 +0000
To: kde-core-devel
Subject: Re: KDatePicker improvements
Message-Id: <200711221030.26936.michael.pyne () kdemail ! net>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=119574584507248
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1922557.7y6iP0e6rq"

--nextPart1922557.7y6iP0e6rq
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Thursday 22 November 2007, Jakob Petsovits wrote:
> So...
> * is the patch ok from a technical point of view?
> * ok to apply? if yes, instantly or on Monday?
> * if no, what do I need to leave out?

Kind of late to the discussion by I think the following:

* As already mentioned, the dialog is too narrow now.  It may be size hint =
or=20
whatever but there needs to be some padding between the text.
* I like the double-arrow thing.  The Week combobox dropdown may be a bit t=
oo=20
big as already mentioned.
* The new features are probably too late for KDE 4. (But remember it can go=
 in=20
as soon as 4.1 is branched)
* This should be a separate request but since you're working on it, is ther=
e=20
*any way* to get some lines drawn in between the days?  Not full contrast=20
black but maybe a light gray.  Every calendar I've ever seen has lines=20
bordering the days.

Looks like good work though.

Regards,
 - Michael Pyne

--nextPart1922557.7y6iP0e6rq
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQBHRaCSqjQYp5Omm0oRAnFPAJ4xtidkImTT3YuHtAp7toR+DIFJhACghCdB
VE1q78yOVLwJhvDAu8wmlH8=
=+qA2
-----END PGP SIGNATURE-----

--nextPart1922557.7y6iP0e6rq--