--nextPart3246642.yzOyK3fbsg
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Wednesday 21 November 2007, Dirk Mueller wrote:
> On Friday 16 November 2007, Allen Winter wrote:
> > Vir and I think we should add the gcc option -Woverloaded-virtual to the
> > CXXFLAGS. Can we do this?
>
> I don't think its a good idea to enable it. did you see the spam of
> warnings it causes, where 70% of them are false?

I've not looked at many of them yet. But for every one I've looked at I got=
=20
the impression that if the warning would have been there from since the cod=
e=20
was written it wouldn't look like it does now. I.e. the warnings show eithe=
r=20
bad style or a problem in the API that can result in unexpected behaviour.

Now I agree that there are many places where we can't do much about it. But=
=20
still I believe new code should always take this warning into account. And =
to=20
make life easier our headers should be clean wrt -Woverloaded-virtual if=20
possible.

What about "using" statements to silence some warnings where applicable? Th=
ey=20
don't change anything wrt the resulting code, right? I remember that we had=
=20
compiler issues with using at some point, do we still support compilers tha=
t=20
don't like using?

> Much better is it to check for the coverity reports, since they have a mu=
ch
> higher signal/noise ratio.

Coverity didn't didn't tell me about the issues I fixed since I enabled the=
=20
warning...

=2D-=20
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz@gmx.net, kretz@kde.org,
Matthias.Kretz@urz.uni-heidelberg.de

--nextPart3246642.yzOyK3fbsg
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBHRDvcyg4WnCj6OIoRAmZEAKDQHslEDWgPzNsnL5xqOcEbIjYwGgCfYFZg
KTaTYeIC5LUZyitqfrcoHo8=
=l5Xb
-----END PGP SIGNATURE-----

--nextPart3246642.yzOyK3fbsg--