[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] kdelibs/kdeui/kdatepicker.cpp
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-11-08 23:21:03
Message-ID: 200711081621.04269.aseigo () kde ! org
[Download RAW message or body]


On Thursday 08 November 2007, John Layt wrote:
> On Thursday 08 November 2007, Aaron J. Seigo wrote:
> > On Wednesday 07 November 2007, John Layt wrote:
> > > OK to commit?
> >
> > the code looks right upon careful reading of it[1], but i'm far from
> > familiar with the internals of this class. are there unit tests for these
> > issues that can go along with the fixes to both prevent regressions as
> > well as prove these things work? =)
> >
> > [1] took a moment for me to see that weekYear was getting passed in by
> > reference to a method that is in an i18n statement. =) might be worth a
> > commentin the code there noting the dual purpose of the next line?
> > *shrug*
>
> Reworked patch attached with better comments and clearer workings.

for someone not intimately faimiliar with these things, this patch looks a lot 
clearer =) thanks...

> At the moment, the unit test consists of running
> kdecore/kdeui/tests/kdatepicktest and manually selecting dates, then
> manually comparing to the KDE3 version.  Proper unit tests are planned for
> 4.1.

sweet.

> P.S. D'oh, just remembered about the kdelibs-bugs list...

heh.. well, as long as it gets fixed that's all that matters =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]