--Boundary-00=_D3kMHCJQgJROG5U Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Wednesday 07 November 2007, Maksim Orlovich wrote: > > On Monday 05 November 2007, Alexander Neundorf wrote: > >> On Monday 05 November 2007, you wrote: > > > > ... > > > >> > And I agree. We shouldn't be linking to plugins. > >> > >> So, does anybody else still have objections against removing > >> "WITH_PREFIX" > >> ? > > > > So, conclusion: I'll remove the "WITH_PREFIX" option and no plugins will > > have > > the "lib" prefix anymore, I'll commit next monday. > > Please make sure you don't break any kpart loading when doing that, e.g. > for nspluginviewer's kpart. Any special reason why you expect a problem there ? The patch for kdelibs/cmake/modules/KDE4Macros.cmake is attached, can you please try ? Alex --Boundary-00=_D3kMHCJQgJROG5U Content-Type: text/x-diff; charset="iso-8859-1"; name="no_WITHPREFIX.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="no_WITHPREFIX.patch" Index: KDE4Macros.cmake =================================================================== --- KDE4Macros.cmake (revision 734069) +++ KDE4Macros.cmake (working copy) @@ -591,6 +591,7 @@ macro (KDE4_ADD_PLUGIN _target_NAME _with_PREFIX) #is the first argument is "WITH_PREFIX" then keep the standard "lib" prefix, otherwise set the prefix empty if (${_with_PREFIX} STREQUAL "WITH_PREFIX") + message(STATUS "Deprecated \"WITH_PREFIX\" used in KDE4_ADD_PLUGIN( ${_target_NAME} ...), please remove it, it is not supported anymore.") set(_first_SRC) else (${_with_PREFIX} STREQUAL "WITH_PREFIX") set(_first_SRC ${_with_PREFIX}) @@ -605,9 +606,9 @@ add_library(${_target_NAME} MODULE ${_SRCS}) endif (KDE4_ENABLE_FINAL) - if (_first_SRC) +# if (_first_SRC) set_target_properties(${_target_NAME} PROPERTIES PREFIX "") - endif (_first_SRC) +# endif (_first_SRC) kde4_handle_rpath_for_library(${_target_NAME}) --Boundary-00=_D3kMHCJQgJROG5U--