[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] KConfigGroup
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2007-11-02 23:35:02
Message-ID: 20071102233502.GB24170 () ugly ! local
[Download RAW message or body]

On Fri, Nov 02, 2007 at 11:47:34PM +0100, Jaroslaw Staniek wrote:
> QByteArray overloads removed; rarely used, some low-level function
> moved to char* versions,
>
in principle i'm fine with this, even if not exactly happy. api-wise, we
aren't losing a lot with this.

you also did another significant change: the read/write functions for
the directly supported data types are no more template spcializations.

i'm wondering how the changes behave when isolated from each other.

> By the way I've provided some cosmetic changes.
>
do you realize that this makes reviewing the patch a complete nightmare?
you really should have held back the search&replace orgy. please undo it
as far as possible (unapply the patch, perform the inverse s&r on the
patch so the relevant chunks become no-ops, re-apply the patch and
re-diff it).

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.
[prev in list] [next in list] [prev in thread] [next in thread]