--nextPart2718590.adZdjXFM3g
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Monday 29 October 2007, Oswald Buddenhagen wrote:
> On Sun, Oct 28, 2007 at 10:20:34PM -0600, Aaron J. Seigo wrote:
> > were there specific reasons for using kFatal that warrant keeping it
> > that way?
>
> well, it is a coding error, not a runtime error. we can't have

it's a coding error on the part of KConfig afaic. and dumping the entire=20
config just because *one entry* is not supported is completely daft.

> compile-time checking, so at least kFatal should be used to avoid the
> error slipping through the cracks - seriously, who reads stdout/stderr
> unless an error is blatantly obvious and "suggests" that something might
> have been logged about it?

the problem is that this is the kind of thing that is easy to slip out into=
 a=20
production release. all it takes is one particular setting not being tested=
=20
that happens to use an unsupported type (thank goodness i use QRectF in=20
plasma, huh?) and there we have it: an app that will crash for 1000s of=20
users.

moreover, i didn't even *notice* that the app was terminating prematurely=20
because it was happening on app exit and there wasn't any further debug=20
output expected at that point. it looked like the app terminated normally, =
to=20
be honest.

i noticed the problem by. ...... reading the errors on stdout. so seriously=
=20
who reads it? me. and because the error was obvious: it had decided not to=
=20
save the configuration values.

at least now the debug output says what's actually happening versus the=20
previously rather unhelpful "unhandle type" message ;)

=2D-=20
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

--nextPart2718590.adZdjXFM3g
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBHJgka1rcusafx20MRAq2oAJ4knMXtBamIfd5BiBlvaa9C9QlJzQCfTpEs
w0PER1lBlKHIRQxR7MI2mUU=
=/IM1
-----END PGP SIGNATURE-----

--nextPart2718590.adZdjXFM3g--