[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: [PATCH] focus on location linedit in file dialog
From: Matt Rogers <mattr () kde ! org>
Date: 2007-10-28 17:00:32
Message-ID: 100B0921-FE6F-446C-A102-D6ABDE571D44 () kde ! org
[Download RAW message or body]
On Oct 28, 2007, at 11:09 AM, Paolo Capriotti wrote:
> Hi,
> in FileWidget constructor there is a call to locationEdit->setFocus
> () that
> is overridden by a later call to KUrlNavigator::setUrlEditable.
> The attached patch moves the setFocus call at the end of the
> function, so
> that it is effective.
>
> Paolo Capriotti
>
> <location-focus.patch>
Looks fine. Please commit
--
Matt
[Attachment #3 (unknown)]
<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: \
after-white-space; "><BR><DIV><DIV>On Oct 28, 2007, at 11:09 AM, Paolo Capriotti \
wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite"><DIV \
style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; \
">Hi,</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; \
margin-left: 0px; ">in FileWidget constructor there is a call to \
locationEdit->setFocus() that</DIV><DIV style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px; ">is overridden by a later call to \
KUrlNavigator::setUrlEditable.</DIV><DIV style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px; ">The attached patch moves the setFocus call at \
the end of the function, so</DIV><DIV style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px; ">that it is effective.</DIV><DIV \
style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; \
min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px; ">Paolo Capriotti</DIV><DIV style="margin-top: \
0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; \
"><BR><SPAN><DIV><location-focus.patch></DIV></SPAN></DIV></BLOCKQUOTE></DIV><DIV><BR \
class="khtml-block-placeholder"></DIV>Looks fine. Please \
commit<DIV>--</DIV><DIV><DIV> <SPAN class="Apple-style-span" style="border-collapse: \
separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; \
letter-spacing: normal; line-height: normal; text-align: auto; \
-khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: \
auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: \
0px; "><SPAN class="Apple-style-span" style="border-collapse: separate; \
border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: \
12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: \
normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: \
none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: \
2; white-space: normal; widows: 2; word-spacing: 0px; "><DIV>Matt</DIV><BR \
class="Apple-interchange-newline"></SPAN></SPAN> </DIV><BR></DIV></BODY></HTML>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic