From kde-core-devel Fri Oct 12 18:25:16 2007 From: Matthew Woehlke Date: Fri, 12 Oct 2007 18:25:16 +0000 To: kde-core-devel Subject: Re: setting tooltip colors Message-Id: X-MARC-Message: https://marc.info/?l=kde-core-devel&m=119221359124864 (It would be nice if I wasn't talking to myself...) Matthew Woehlke wrote: > Matthew Woehlke wrote: >> It came to my attention (1) that AFAIK (also tested by jpwhiting) KDE >> doesn't actually /set/ tooltip colors yet. As I recall, setting them >> means calling a Qt method, i.e. I am not sure if we can enforce KDE's >> color preference for non-KDE applications. Anyway, this will require a >> change in libs; unless someone has a better idea, I guess it will mean >> setting the colors in KGlobalSettings::createApplicationPalette. >> >> I'll post the patch when it's ready, but this is a heads-up that a >> change is needed (and a call for ideas if anyone has better knowledge >> than me). I do not expect this to affect BC/SC in any way. >> >> 1: http://permalink.gmane.org/gmane.comp.kde.general/17490 > > Here is the patch (attached; tested with kwrite). Can I please get an > go/no-go to commit this? So, um... why has no one objected yet? ;-) I was going to suggest using KGS::createApplicationPalette to jpwhiting for the color kcm (for scheme preview icons), and realized that introducing side effects here is almost certainly a *bad* idea :-). Which means we really do need an API change :-(. Since it would be useful to styles also (well, eventually just KStyle I hope), I'd like to add createTooltipPalette along-side createApplicationPalette, which will then be used by I assume KApplication (wherever createApplicationPalette currently works its magic, anyway). A new method will also mean that oxygen/kstyle can DTRT without duplicating code (because createTooltipPalette will not actually set the palette). I'll try to prepare a new patch tonight. (Is it ok to commit *new* API on not-Monday, as long as I wait for a Monday to use it?) -- Matthew Microsoft: driving people fscking insane...