[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    AW: KConfig/KLockFile performance (was KMimeType performance)
From:       "Nhuh Put" <nhuh.put () web ! de>
Date:       2007-10-09 20:39:08
Message-ID: 01ad01c80ab4$71ad8f50$ad5d66d5 () spika
[Download RAW message or body]

Von: Thomas Braxton
Gesendet: Dienstag, 9. Oktober 2007 21:22
An: kde-core-devel@kde.org
Betreff: Re: KConfig/KLockFile performance (was KMimeType performance)

> On 10/9/07, David Faure <faure@kde.org> wrote: 
> On Tuesday 09 October 2007, Maksim Orlovich wrote:
> > KDesktopFile/KConfig tries to lock the file with KLockFile
> 
> Huh. I thought we got rid of the "bool readonly" because it made no behavior \
> difference,  but if KConfig locks the file then surely we need a "ReadOnly" flag \
> again? Or better: we should lock at the time of writing to the file, not when just \
> reading from it! 
> your mail came in as I was sending the last patch, here's another try. this time \
> only locking in sync() and only if the file is read-write.

This should work, but there is one problem: configState is only set to ReadOnly in
KConfig::isConfigWritable, which is normally not called, so there should probably be
a call to it in KConfigPrivate::changeFileName, or this will not have much effect.

	PutHuhn

 


[prev in list] [next in list] [prev in thread] [next in thread]