[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDE Printing API Request (Was: [REMINDER] KDE Dev Platform FROZEN)
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2007-10-09 7:13:17
Message-ID: 200710090913.17607.hausmann () kde ! org
[Download RAW message or body]


On Sunday 07 October 2007 23:24:54 David Faure wrote:
> On Saturday 06 October 2007, Alex Merry wrote:
> > On Saturday 06 Oct 2007, Allen Winter wrote:
> > > PS.  KSSL and printing stuff still needs work.  We can still accept
> > > code that improves those areas at any time. :)
> >
> > Hopefully the last API bit for printing, bar removing libkdeprint:
> >
> > Is this patch OK to commit?  It doesn't do anything interesting at the
> > moment, but provides the API for getting a customised QPrintDialog.
> >
> > The methods return a QAbstractPrintDialog *, but in actual fact it's a
> > QPrintDialog *.  Does this cause problems for deleting (the caller
> > takes ownership)?
>
> No, it doesn't cause problems, since the destructor is virtual in all
> QObjects [as it should be in any class with virtual methods, anyway].

I still suggest to return a QPrintDialog instead of a QAbstractPrintDialog. 
The latter is a useless class, it does not provide any abstraction. I don't 
recommend its use in the public API.


Simon

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]