[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Make WhatsThis texts appear for composite widgets
From:       Matt Rogers <mattr () kde ! org>
Date:       2007-09-29 17:13:14
Message-ID: 200709291213.14675.mattr () kde ! org
[Download RAW message or body]

On Saturday 29 September 2007 10:14:41 am David Jarvie wrote:
> KWhatsThisManager outputs a default WhatsThis text inviting the user to
> submit suggestions for texts whenever the user asks for a WhatsThis text
> for a widget which doesn't have one. However, when a widget has child
> widgets, and the parent widget does have a WhatsThis text, the default text
> is output for all the child widgets instead of outputting the parent's
> WhatsThis text. This means that many widgets which actually do have
> WhatsThis texts display instead the default text, simply because each
> individual component of a composite widget hasn't been separately supplied
> with (the same) WhatsThis text. This is a real reduction in usability, the
> opposite of what
> KWhatsThisManager is intended to achieve.
>
> I attach a patch which checks for the existence of a WhatsThis text in the
> parent (and grandparent, etc...) widget before deciding to output the
> default WhatsThis message.

The patch looks correct to me.
--
Matt
[prev in list] [next in list] [prev in thread] [next in thread]