[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KUser windows port and small API changes
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2007-09-24 17:18:54
Message-ID: 20070924171854.GA15936 () ugly ! local
[Download RAW message or body]

On Sun, Sep 23, 2007 at 01:40:59AM +0200, Bernhard Loos wrote:
> +++ kuser.cpp	(working copy)
> +  /**
> +   * Retruns an extended property or an invalid
>
spelling

> +   * QVariant if the property is not set.
> +   *
> +   * currently supported properties: roomnumer, workphone and homephone
> +   *
>
"Supported properties on UNIX: @c roomnumer, @c workphone and @c homephone.
Under Windows, no extended properties are supported currently."

> +   * \return a QVariant with value of the property
>
please use @ consistently.
actually, i prefer to document the "failure" case here and take out the
"or invalid", etc. from the description above. oh, well ...

> +   */
> +  QVariant extendedProperty(const QByteArray &which) const ;
> 
stray space.

other than that, the patch is pre-approved by me and will go in today
unless somebody cries out *now*.

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.
[prev in list] [next in list] [prev in thread] [next in thread]