[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDE/kdelibs/kdeui/colors
From:       Matthew Woehlke <mw_triad () users ! sourceforge ! net>
Date:       2007-09-16 19:00:08
Message-ID: fcjufo$pbe$1 () sea ! gmane ! org
[Download RAW message or body]

Thomas Zander wrote:
> I guess we are past the point where I explain that all I did was remove 
> a lot of duplicate code :-)

I understand that, but please realize that I made a conscious decision 
at the time I originally wrote this code to not write it the way you did.

> What about this patch to finalize the effect-defaults for 'Inactive' being 
> the same as the normal colors?
> [snip patch]

Please change this patch so that the default effect for Inactive is 
IntensityNoEffect, as this is a bit more efficient than amount==0. 
Otherwise, no objections; it will suffice for now.

-- 
Mathew
(sorry, .sig file is on the other computer)

[prev in list] [next in list] [prev in thread] [next in thread]