[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    AW: KLibrary
From:       "Nhuh Put" <nhuh.put () web ! de>
Date:       2007-09-15 10:18:04
Message-ID: 016001c7f781$b480cbd0$68c8a8c0 () spika
[Download RAW message or body]

> Von: thiago@kde.org
> Gesendet: Freitag, 14. September 2007 13:34
> An: kde-core-devel@kde.org; nhuh.put@web.de
> Betreff: Re: KLibrary
> 
> On Friday 14 September 2007 10:56:47 Nhuh Put wrote:
> > Hello
> > I would like to apply this patch to KLibLoader next Monday. It moves the
> > KLibrary class into its own file and makes it inherit QLibrary. With
> this
> > change, the Library loading system is much smaller and thread-safe.
> > I have also removed the unloading stuff from KLibLoader as this is not
> > supported anymore.
> > This shouldn't include any SC changes as KLibrary::name is unused afaics
> >
> > 	PutHuhn
> 
> You have some private functions in KLibrary. They mustn't be there.

I can remove them, but I would like to know why. 

> 
> Also, since QLibrary can unload and you're not overriding anything there,
> KLibrary can still be unloaded. And you've removed the clipboard-unset
> hook.

I would like to keep a working unload method and remove all calls to it in
current KDE. I would also add some comments in the docs regarding it,
similar to KPluginLoader. So if an application really wants to use it and
the author knows what he is doing, it's still possible. 
If unloading is not supported, the clipboard hook wouldn't be needed any
more, would it?

> 
> --
>   Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
>     PGP/GPG: 0x6EF45358; fingerprint:
>     E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358


[prev in list] [next in list] [prev in thread] [next in thread]