From kde-core-devel  Fri Sep 14 22:06:49 2007
From: Thiago Macieira <thiago () kde ! org>
Date: Fri, 14 Sep 2007 22:06:49 +0000
To: kde-core-devel
Subject: Re: KDE4 printing: results of IRC meeting
Message-Id: <200709150006.49669.thiago () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=118980772628853
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart2899270.6TVMesG9IW"

--nextPart2899270.6TVMesG9IW
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Bart Coppens wrote:
>On Friday 14 September 2007 23:51, Thiago Macieira wrote:
>> KDE Libs 4.0's printing will work only on Qt 4.3.2 because it will do
>> a very ugly hack of modifying QPrintDialog. If you upgrade Qt without
>> upgrading KDE, you will very likely lose those extra configuration
>> pages. (Which Windows and Mac users won't be seeing anyways)
>
>Wow. This completely defeats the idea of backwards-compatibility.=20
> Purposely depending on code of which you know it will be
> ABI/API-incompatible in the next release sounds like a *very* bad idea
> to me.

We do that all over the place with Qt. We use a lot of internals.

In this case, what this hack is about is to get the QPrintDialog -- which=20
is a QDialog -- find the widget called "generalWidget", add a QTabWidget=20
as its parent and insert it into the dialog. And keep the button box in=20
the proper place.

This obviously depends on the internal construction of the dialog. That's=20
why it won't work with the native dialogs.

The only alternative I can see is to write a KPrintDialog. We won't be=20
able to get rid of it until KDE 5.
=2D-=20
=A0 Thiago Macieira =A0- =A0thiago (AT) macieira.info - thiago (AT) kde.org
=A0 =A0 PGP/GPG: 0x6EF45358; fingerprint:
=A0 =A0 E067 918B B660 DBD1 105C =A0966C 33F5 F005 6EF4 5358

--nextPart2899270.6TVMesG9IW
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQBG6wX5M/XwBW70U1gRAokvAKDC20Uf9GvYuywp64uT71YC/ti67ACgj7OC
lZ3ShtChvdx5VM4f+hipSLk=
=J99T
-----END PGP SIGNATURE-----

--nextPart2899270.6TVMesG9IW--