[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Temporary KColorScheme change - hard-code some state colors
From:       Kevin Ottens <ervin () kde ! org>
Date:       2007-09-14 15:44:19
Message-ID: 200709141744.24737.ervin () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


Le vendredi 14 septembre 2007, Matthew Woehlke a écrit :
> Maksim Orlovich wrote:
> > Well, and I warned Matthew that active != inactive would likely cause
> > flicker, asked him to test it before changing to it and....
>
> ...and I did, and obviously your definition of "flicker" differs from mine.

Actually we got this discussion yesterday on IRC. It seems your definition of 
flicker differs from everyone else.

I'm proposing to commit this patch until you come up with a sane solution for 
whatever you're trying to achieve (I hope the whole point is not switching 
palettes because we can).

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."

["no_palette_flickering.patch" (text/x-diff)]

Index: kcolorscheme.cpp
===================================================================
--- kcolorscheme.cpp	(révision 712473)
+++ kcolorscheme.cpp	(copie de travail)
@@ -37,8 +37,6 @@
     // TODO - eventually, it would be great if this actually worked on brushes
     // FIXME - this code is temporary, proof-of-concept
     switch (state) {
-        case QPalette::Inactive:
-            return QBrush(KColorUtils::darken(brush.color(), 0.2));
         default:
             return brush;
     }
@@ -53,8 +51,6 @@
     // TODO - eventually, it would be great if this actually worked on brushes
     // FIXME - this code is temporary, proof-of-concept
     switch (state) {
-        case QPalette::Inactive:
-            return QBrush(KColorUtils::darken(brush.color(), 0.2));
         case QPalette::Disabled:
             return QBrush(KColorUtils::mix(brush.color(), background.color(), 0.7));
         default:

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]