[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KPageWidget forces icons to 32x32
From:       Allen Winter <winter () kde ! org>
Date:       2007-09-05 18:00:29
Message-ID: 200709051400.29606.winter () kde ! org
[Download RAW message or body]

On Wednesday 05 September 2007 4:02:46 am David Faure wrote:
> On Wednesday 05 September 2007, Jason 'vanRijn' Kasper wrote:
> > I don't believe I ever saw any responses to my question.  The situation is 
> > still the same, I believe.  The size of the pixmap is still being hard-coded 
> > to 32x32:
> > 
> > .-(~/kde4/src/kdelibs/kdeui/paged)-
> > `--> grep 32 *
> > kpageview_p.cpp:  const QPixmap pixmap = icon.pixmap( 32, 32 );
> > kpageview_p.cpp:  const QPixmap pixmap = icon.pixmap( 32, 32 );
> > 
> > I guess that for KPilot, it's not that big of a deal, and we certainly have 
> > bigger problems than the size of our icons not being the same size that they 
> > were in kde3.  If nobody else is complaining about it, I'm content to drop 
> > the issue.  =:)
> 
> This should use KIconLoader::global()->currentSize(K3Icon::Dialog) instead.
> 

Ok, i'm committing that fix as I type this.
Thanks for the feedback David.
[prev in list] [next in list] [prev in thread] [next in thread]