[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KColorScheme - additional (convenience) ctors
From:       Matthew Woehlke <mw_triad () users ! sourceforge ! net>
Date:       2007-09-04 16:05:04
Message-ID: fbjvng$icf$1 () sea ! gmane ! org
[Download RAW message or body]

Allen Winter wrote:
> On Friday 31 August 2007 11:17:51 pm Matthew Woehlke wrote:
>> If no one objects, I would like to add additional ctors to KColorScheme 
>> this Monday (September 3). 
> 
> Was this completed today?

No. I took another look at the existing users, and it seems more people 
than I expected are either caching or adjusting palettes (although I 
didn't see anyone actually Doing The Right Thing yet). So I decided to 
delay this, as I'm not sure it is needed (at least in current form; see 
below) after all.

I was already considering porting adjustBackground from 
kdelibs/kate/utils/katesearchbar.cpp to KColorScheme, as this is a 
convenient paradigm that looks like it will allow direct ports of 
several of the existing users (the others... seriously tempt me to add a 
KStateColor class, otherwise we have a Big Mess*; this would have 
/accessors/ that take QPalette/QWidget like the original KCS proposal).

(* rather, we do if QPalette::ColorGroup changes... which it should, as 
it is currently missing a value.)

So I'm going to try to start porting some users locally and see what I 
actually need, and come back with something different for next week.

-- 
Matthew
When in doubt, duct tape!

[prev in list] [next in list] [prev in thread] [next in thread]