[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] New image loader (Softimage PIC)
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2007-08-31 20:54:09
Message-ID: 200708312254.11496 () erwin ! ingo-kloecker ! de
[Download RAW message or body]


On Thursday 30 August 2007 10:19, Ruben Lopez wrote:
> Ingo Klöcker wrote:
> > I am much more concerned about the usage of the arithmetic shift
> > operator on variables of type unsigned char. A char is 8 bit wide
> > so for example b << 8 might be 0 for some compilers/on some
> > architectures. Or does char always expand to a 32-bit integer when
> > its bits are shifted? I guess the answer is "It _should_ on 32+-bit
> > architectures."
> >
> > I have observed a weird problem with a few signed chars being
> > casted to float and back which yielded different results in debug
> > and release builds with vc7, so I wouldn't be surprised if the
> > above would still break for some compiler.
>
> I have changed these unsigned char to unsigned. This should fix the
> problem on most architectures.

Good.

> Anyway, when integrating this code 
> with kdelibs or kdegraphics configure (CMake?) system, maybe I could
> use more portable types (like uint32 or something like that).
> About the float problems, where did you identified them?

Sorry for causing confusion. Those float problems occurred in a totally 
different project. I just mentioned them as an example.


Regards,
Ingo

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]