[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Fix a crash in KSharedConfigPtr
From:       Matthias Kretz <kretz () kde ! org>
Date:       2007-08-30 17:52:09
Message-ID: 200708301952.12950.kretz () kde ! org
[Download RAW message or body]


On Thursday 30 August 2007, Alex Merry wrote:
> I'm getting a crash in plasma caused by setting a KSharedConfigPtr to 0.
> It causes KSharedConfigPtr::attach(0) to be called, and then tries to
> dereference p (which is 0).
>
> This patch should fix it, but I'm not certain it's correct.  Can someone
> tell me whether it makes sense?

Good catch, your fix is correct. And I think I should document that code a bit 
more...

-- 
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz@gmx.net, kretz@kde.org,
Matthias.Kretz@urz.uni-heidelberg.de

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]