[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Using KIcon for icons with overlay
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-08-30 3:50:46
Message-ID: 200708292150.46446.aseigo () kde ! org
[Download RAW message or body]


On Wednesday 29 August 2007, Olivier Goffart wrote:
> Le mercredi 29 août 2007, Gustavo Pichorim Boiko a écrit  :
> > So I'm open for suggestions on how this could be handle.
>
> Personally, what I would have done is adding a color argument to
> KIconLoader::loadIcon()    (in a overloaded version)
>
> and either :
>
>  - Add the same argument to one KIcon constructor
> or
>  - Don't use KIcon for status icons in Kopete, but a QIcon using a
> KopeteIconEngine which derive from QIconEngine and which use KIconLoader.

and i suppose you'd have to then pass in QStringList() for the overlays to 
iconLoader, apply the effect, then call d->drawOverlays at that point.

to avoid being colour specific, why not take a full effect specification? man, 
will _that_ be an ugly method signature when it's all said and done...

i really don't know which approach is the Least Fugly.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]