[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: About Dialogs review
From: "=?UTF-8?Q?Rafael_Fern=C3=A1ndez_L=C3=B3pez?=" <ereslibre () gmail ! com>
Date: 2007-08-27 15:15:06
Message-ID: 93f85fee0708270815h30e1b40cy2cef912a767cc9af () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
[Attachment #4 (text/plain)]
Hi all,
Despite the fact that right now About dialogs are screwed up because some
tags have been removed... I have been taking a look to see if they could be
even "better looking".
On the "About KDE" dialog I also did Konqui look transparent (note that I'm
_not_ good with graphics, and I know it can be really improved). However I
miss a SVG Konqui to make that dialog more fresh and different looking than
KDE 3 versions.
The result is on:
http://media.ereslibre.es/2007/08/aboutdolphinscreen.png
http://media.ereslibre.es/2007/08/aboutkwritescreen.png
http://media.ereslibre.es/2007/08/aboutkdescreen.png
The patch is attached, and the binary file that can't be diff is on here:
http://media.ereslibre.es/2007/08/aboutkde.png
As I say it would be really nice a SVG version of our Konqui that is resized
when that window is resized.
Please take in count that the patch contains some other things unrelated
(like the fix of the problems that already happens on SVN to the About
dialogs).
The main reason for this change is that the white background we were having
made the dialog look strange (at least to me), and the About KDE dialog even
more weird, because we had the Konqui background and the title background,
separated by the layout separation.
Bye,
Rafael Fernández López.
[Attachment #5 (text/html)]
Hi all,<br><br>Despite the fact that right now About dialogs are screwed up because \
some tags have been removed... I have been taking a look to see if they could be even \
"better looking".<br><br>On the "About KDE" dialog I also did \
Konqui look transparent (note that I'm _not_ good with graphics, and I know it \
can be really improved). However I miss a SVG Konqui to make that dialog more fresh \
and different looking than KDE 3 versions. <br><br>The result is on:<br><a \
href="http://media.ereslibre.es/2007/08/aboutdolphinscreen.png">http://media.ereslibre.es/2007/08/aboutdolphinscreen.png</a><br><a \
href="http://media.ereslibre.es/2007/08/aboutkwritescreen.png"> \
http://media.ereslibre.es/2007/08/aboutkwritescreen.png</a><br><a \
href="http://media.ereslibre.es/2007/08/aboutkdescreen.png">http://media.ereslibre.es/2007/08/aboutkdescreen.png</a><br><br>The \
patch is attached, and the binary file that can't be diff is on here: <br><a \
href="http://media.ereslibre.es/2007/08/aboutkde.png">http://media.ereslibre.es/2007/08/aboutkde.png</a><br><br>As \
I say it would be really nice a SVG version of our Konqui that is resized when that \
window is resized. <br><br>Please take in count that the patch contains some other \
things unrelated (like the fix of the problems that already happens on SVN to the \
About dialogs).<br><br>The main reason for this change is that the white background \
we were having made the dialog look strange (at least to me), and the About KDE \
dialog even more weird, because we had the Konqui background and the title \
background, separated by the layout separation. <br \
clear="all"><br><br>Bye,<br>Rafael Fernández López.
["kdeui.diff" (text/x-diff)]
Index: kdeui/dialogs/aboutkde.png
===================================================================
No se puede mostrar: el archivo está marcado como binario.
svn:mime-type = image/png
Index: kdeui/dialogs/kaboutkdedialog.cpp
===================================================================
--- kdeui/dialogs/kaboutkdedialog.cpp (revisión: 705050)
+++ kdeui/dialogs/kaboutkdedialog.cpp (copia de trabajo)
@@ -31,6 +31,7 @@
#include <klocale.h>
#include <kstandarddirs.h>
#include <ktitlewidget.h>
+#include <kiconloader.h>
KAboutKdeDialog::KAboutKdeDialog(QWidget *parent)
: KDialog(parent),
@@ -43,7 +44,8 @@
setModal(false);
KTitleWidget *titleWidget = new KTitleWidget(this);
- titleWidget->setText(i18n("<font size=\"4\">K Desktop Environment</font><br \
/><b>Version %1</b>", QString(KDE_VERSION_STRING))); + \
titleWidget->setText(i18n("<font size=\"5\">K Desktop Environment</font><br \
/><b>Version %1</b></html>", QString(KDE_VERSION_STRING))); + \
titleWidget->setPixmap(KIconLoader::global()->loadIcon("kmenu", K3Icon::Desktop), \
KTitleWidget::ImageLeft);
QLabel *about = new QLabel;
about->setMargin(10);
@@ -58,7 +60,7 @@
"No single group, company or organization controls the KDE source "
"code. Everyone is welcome to contribute to KDE.<br /><br />"
"Visit <a href=\"http://www.kde.org/\">http://www.kde.org</a> for "
- "more information on the KDE project."));
+ "more information on the KDE project.</html>"));
QLabel *report = new QLabel;
report->setMargin(10);
@@ -75,7 +77,7 @@
"use the \"Report Bug...\" dialog from the \"Help\" menu to report bugs.<br \
/><br />"
"If you have a suggestion for improvement then you are welcome to use "
"the bug tracking system to register your wish. Make sure you use the "
- "severity called \"Wishlist\"." ));
+ "severity called \"Wishlist\".</html>" ));
QLabel *join = new QLabel;
join->setMargin(10);
@@ -95,7 +97,7 @@
"<br /><br />"
"If you need more information or documentation, then a visit to "
"<a href=\"http://techbase.kde.org/\">http://techbase.kde.org</a> "
- "will provide you with what you need."));
+ "will provide you with what you need.</html>"));
QLabel *support = new QLabel;
support->setMargin(10);
@@ -115,7 +117,7 @@
"contributing to KDE. You are encouraged to support KDE through a financial \
" "donation, using one of the ways described at "
"<a href=\"http://www.kde.org/support/\">http://www.kde.org/support/</a>."
- "<br /><br />Thank you very much in advance for your support."));
+ "<br /><br />Thank you very much in advance for your support.</html>"));
QTabWidget *tabWidget = new QTabWidget;
tabWidget->setUsesScrollButtons(false);
@@ -125,10 +127,6 @@
tabWidget->addTab(support, i18n("&Support KDE"));
QLabel *image = new QLabel;
- image->setFrameShape(QFrame::StyledPanel);
- image->setFrameShadow(QFrame::Plain);
- image->setAutoFillBackground(true);
- image->setBackgroundRole(QPalette::Base);
image->setPixmap(KStandardDirs::locate("data", "kdeui/pics/aboutkde.png"));
QHBoxLayout *midLayout = new QHBoxLayout;
Index: kdeui/dialogs/kaboutapplicationdialog.cpp
===================================================================
--- kdeui/dialogs/kaboutapplicationdialog.cpp (revisión: 705050)
+++ kdeui/dialogs/kaboutapplicationdialog.cpp (copia de trabajo)
@@ -80,7 +80,7 @@
else if (aboutData->programLogo().canConvert<QImage>())
titleWidget->setPixmap(QPixmap::fromImage(aboutData->programLogo().value<QImage>()), \
KTitleWidget::ImageLeft);
- titleWidget->setText(i18n("<font size=\"5\">%1</font><br /><b>Version %2</b><br \
/>Using KDE %3", aboutData->programName(), + titleWidget->setText(i18n("<font \
size=\"5\">%1</font><br /><b>Version %2</b><br />Using KDE %3</html>", \
aboutData->programName(),
aboutData->version(), QString(KDE_VERSION_STRING)));
QTabWidget *tabWidget = new QTabWidget;
Index: kdeui/widgets/ktitlewidget.cpp
===================================================================
--- kdeui/widgets/ktitlewidget.cpp (revisión: 705050)
+++ kdeui/widgets/ktitlewidget.cpp (copia de trabajo)
@@ -82,10 +82,6 @@
d(new Private(this))
{
QFrame *titleFrame = new QFrame(this);
- titleFrame->setAutoFillBackground(true);
- titleFrame->setFrameShape(QFrame::StyledPanel);
- titleFrame->setFrameShadow(QFrame::Plain);
- titleFrame->setBackgroundRole(QPalette::Base);
// default image / text part start
d->headerLayout = new QGridLayout(titleFrame);
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic