From kde-core-devel  Sun Aug 26 10:23:25 2007
From: Simon Hausmann <hausmann () kde ! org>
Date: Sun, 26 Aug 2007 10:23:25 +0000
To: kde-core-devel
Subject: Re: [PATCH] kdeui/dialogs/kmessagebox.cpp
Message-Id: <200708261223.28981.hausmann () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=118812386019198
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1223957.v5CLbgCcMF"

--nextPart1223957.v5CLbgCcMF
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Saturday 25 August 2007 21:27:29 Rafael Fern=C3=A1ndez L=C3=B3pez wrote:
> Hi,
>
> I would like if this is OK to commit. I wonder if this is internally done
> by Qt if it is compiled with RIGHT_TO_LEFT symbol.
>
> I also wonder how this works on distributions. They always ship Qt compil=
ed
> with LEFT_TO_RIGHT so we have to check always layoutDirection() ?
>
> For keeping quality on KDE, if the case is that Qt is always shipped
> compiled with left to right support and we need to check layoutDirection(=
),
> I really think we should consider take a look on how things are for RTL
> languages. This "fix" is because KMessageBox is called from
> KPluginSelector, and I noticed that when it was shown the layout direction
> wasn't respected (I forced it on KPluginSelector to RTL for testing
> purposes).

Widgets inherit the layout direction automatically from their parent unless=
=20
they are windows, in which case the application's layout direction is used.=
=20
Normally there is only one layout direction, which is the application's one=
=2E=20
Only in rare cases I think it makes sense to specifically override it, whic=
h=20
is why you _can_ set it per widget.

But for testing purposes I recommend starting your application with "-rever=
se"=20
or by setting the layout direction manually on the application object.


Simon

--nextPart1223957.v5CLbgCcMF
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBG0VSgWXvMThJCpvIRAk2TAKDT/S69a9/wkJtm/jTQjNRl0I4sEgCgnfeS
rjJpUicEILOrMuvxKjFsvfc=
=zSFn
-----END PGP SIGNATURE-----

--nextPart1223957.v5CLbgCcMF--