[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Konqueror internals question (hunting an annoying KDE3 usability
From:       David Faure <faure () kde ! org>
Date:       2007-08-13 14:31:16
Message-ID: 200708131631.17049.faure () kde ! org
[Download RAW message or body]

On Monday 13 August 2007, Hans Meine wrote:
>  void KonqViewManager::emitActivePartChanged()
>  {
> +    // prevent unnecessary multiple calls to slotPartActivated:
> +    m_activePartChangedTimer->stop();
>      m_pMainWindow->slotPartActivated( activePart() );
>  }

Good point. I didn't notice that it was called from multiple places
(which is why your bug wasn't fixed, while mine was). It certainly makes sense
to stop the timer in all cases when emitting, please commit this. Thanks!

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]