From kde-core-devel  Mon Aug 13 11:51:29 2007
From: David Faure <faure () kde ! org>
Date: Mon, 13 Aug 2007 11:51:29 +0000
To: kde-core-devel
Subject: Re: Konqueror internals question (hunting an annoying KDE3 usability
Message-Id: <200708131351.30914.faure () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=118700594430424

On Monday 13 August 2007, Hans Meine wrote:
> Hi!
> 
> I was just trying to find out why Ctrl-N (new tab) clears the location bar 
> twice.  This annoys me a lot, since I always start typing 
> e.g. "<Ctrl-N>gg:konqueror rules", but end up with "ror rules" in the 
> location bar (especially in high-load situations).  I found out that the 
> guilty KonqMainWindow::slotPartActivated() gets called twice when opening a 
> new tab (both calls via KonqViewManager::emitActivePartChanged()), which 
> looks like a bug AFAICS.
> 
> The reason is that KonqViewManager::showTab()
> 1) first calls showPage(), which leads to a call of setActivePart() that 
> starts m_activePartChangedTimer, and then
> 2) directly calls emitActivePartChanged().
> 3) Then the timer from 1) fires and emitActivePartChanged() is called again.
> 
> What I did not yet find out is why showPage() leads to a call of 
> setActivePart() (although that does not sound wrong in any way).  Now maybe 
> someone with more knowledge of Konquerors internals could comment on this 
> (and the above)?

Damn, this analysis came in a few days too late ;)
I fixed this bug on Friday with r698562
Any chance you can update from svn and confirm that the bug is gone?

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).