[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KConfigDialog patch
From:       "Joris Guisson" <joris.guisson () gmail ! com>
Date:       2007-08-12 8:00:18
Message-ID: 6bc528f40708120100i5f613781m3058c2d09950ff0f () mail ! gmail ! com
[Download RAW message or body]

On 8/12/07, Aaron J. Seigo <aseigo@kde.org> wrote:
>
> On Saturday 11 August 2007, Joris Guisson wrote:
> > It seems to be in the API for quite some time now, so it's a bit strange
> I
> > never discovered this before.
>
> it needs a techbase tutorial =)
>
> > This all then leads to the attached patch. Can this patch be included in
> > kdelibs ?
>
> it seems that the (some of the?) check(s) currently done in showEvent()
> should
> probably also be done when addPage is called? that seems to be the reason
> why
> currently pages aren't allowed to be added, from what i can discern from
> the
> code?


I guess only the default button would have to be updated, the updateWidgets
stuff has all been done for the older pages, and for the new page, my change
in setupWidget would take care of that. The apply button doesn't need to be
changed, because nothing has changed in the new page.


Joris,

--
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>
>

[Attachment #3 (text/html)]

<br><br><div><span class="gmail_quote">On 8/12/07, <b class="gmail_sendername">Aaron \
J. Seigo</b> &lt;<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>&gt; \
wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> On Saturday 11 August \
2007, Joris Guisson wrote:<br>&gt; It seems to be in the API for quite some time now, \
so it&#39;s a bit strange I<br>&gt; never discovered this before.<br><br>it needs a \
techbase tutorial =)<br><br>&gt; This all then leads to the attached patch. Can this \
patch be included in <br>&gt; kdelibs ?<br><br>it seems that the (some of the?) \
check(s) currently done in showEvent() should<br>probably also be done when addPage \
is called? that seems to be the reason why<br>currently pages aren&#39;t allowed to \
be added, from what i can discern from the <br>code?</blockquote><div><br>I guess \
only the default button would have to be updated, the updateWidgets stuff has all \
been done for the older pages, and for the new page, my change in setupWidget would \
take care of that. The apply button doesn&#39;t need to be changed, because nothing \
has changed in the new page. <br><br><br>Joris,</div><br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;">--<br>Aaron J. Seigo<br>humru othro a kohnu se<br>GPG \
Fingerprint: 8B8B 2209 0C6F 7C47 B1EA&nbsp;&nbsp;EE75 D6B7 2EB1 A7F1 DB43 <br><br>KDE \
core developer sponsored by Trolltech<br><br></blockquote></div><br>



[prev in list] [next in list] [prev in thread] [next in thread]