[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KRecentFilesAction
From:       Stefan Nikolaus <stefan.nikolaus () kdemail ! net>
Date:       2007-08-09 18:54:45
Message-ID: 200708092054.49124.stefan.nikolaus () kdemail ! net
[Download RAW message or body]


On Tuesday 07 August 2007 22:16:57 Thiago Macieira wrote:
> Stefan Nikolaus wrote:
> >On Tuesday 07 August 2007 17:12:02 Thiago Macieira wrote:
> >> Now KRecentFilesActionPrivate inherits from KSelectActionPrivate, but
> >> KSelectAction::d is still private, KRecentFilesAction::d is still
> >> there (you have to remove it) and I don't see the new constructor for
> >> passing the shared private.
> >
> >Okay, you're right. It's not that easy. So, my second try's attached.
>
> That looks ok now, from a cursory glance.
>
> I don't understand the Action part of the patch, but the shared-private
> part of it looks fine.

Same as in KSelectAction::addAction(QAction*), except that it prepends the 
action to the lists instead of appending them.

I'll commit  on Monday, if noone objects till then.

Regards,
Stefan

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]