From kde-core-devel  Tue Jul 24 21:45:57 2007
From: Daniel Molkentin <daniel () molkentin ! de>
Date: Tue, 24 Jul 2007 21:45:57 +0000
To: kde-core-devel
Subject: Request for Review: KExpandableWidget into kdeui
Message-Id: <200707242346.00201.daniel () molkentin ! de>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=118531361005027
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1458484.ijrLOMfoUH"

--nextPart1458484.ijrLOMfoUH
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi list,

sorry that this mail makes it on the last date possible but it's finally=20
there, hussah!

I am asking to include KExpandableGroupBox [1] (screenshot at [2]) into SVN=
=2E =20
It behaves similar to a QGroupBox,  but is collapsed by default and can be=
=20
expanded. Inside a QScrollArea it is thus very useful for adding advanced=20
options. The only difference to QGroupBox is that the inner Widget is being=
=20
set via setWidget(), rather than via an explicit layout.  This cannot be=20
changed from my POV, please tell me if I am wrong. Otoh, I think this is a=
=20
fairly minor issue. Did I mention it comes with a fancy expand animation? :=
=2D)

The class lives in playground since about two years and I recently cleaned =
it=20
up: it has API docs, is valuecopy-protected, the member vars are pimpl'ed,=
=20
the ctor is explicit and the API is const correct (at least as far as I can=
=20
see). It also provides a demo (in tests/).

The class is being used inside plasma (holds a private copy) and I have see=
n=20
at least in KToon (a non KDE SVN project) using it [3], both under its old=
=20
name "CollapsibleWidget". Also, it will probably use a lot more in the futu=
re=20
as we come to fix up KControl modules.

So can anyone please have a look? Any objections against having the class i=
n=20
kdeui? I know that the animation could be improved, but that would not affe=
ct=20
the API.

Cheers,
  Daniel

[1]  http://websvn.kde.org/trunk/playground/libs/ui/collapsiblewidget/
[2]  http://developer.kde.org/~danimo/screenies/kexpandablewidget/
[3] =20
http://www.koders.com/cpp/fidC83C8C581A206DC34D4F514E44741EB719D78EC6.aspx

--nextPart1458484.ijrLOMfoUH
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBGpnMYu1Wkf8kBwz4RAoUfAJ9V9xRlqjhsn6mNogDb2Un9/tDkfwCfT8h+
lleGICP44qjIUj2VDhhUTdk=
=1M2z
-----END PGP SIGNATURE-----

--nextPart1458484.ijrLOMfoUH--