[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] ***FINAL*** API review of KCalendarSystem* and KDate*
From:       "David Jarvie" <lists () astrojar ! org ! uk>
Date:       2007-07-23 10:34:04
Message-ID: 36257.S0VKQUNDQxA=.1185186844.squirrel () www ! sensical ! net
[Download RAW message or body]

On Monday 23 July 2007 11:26, Alex Merry wrote:
> On Monday 23 Jul 2007, John Layt wrote:
>> P.S. Quick question, pardon my ignorance on C++ & BIC, but does
>> re-arranging the order of methods in the header change the virtual
>> table?  I want a more logical grouping of methods for the apidox, but
>> doing so now makes the patches very hard to review.
>
> Only if you're changing the order of virtual methods.

You could always apply a separate patch to alter the method order, after
the main patch has been applied. That would make the changes clearer.

-- 
David Jarvie.
KAlarm author & maintainer.
http://www.astrojar.org.uk/kalarm

[prev in list] [next in list] [prev in thread] [next in thread]