[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] kdelibs kio::KDirWatch
From:       Josef Weidendorfer <Josef.Weidendorfer () gmx ! de>
Date:       2007-07-18 14:09:38
Message-ID: 200707181609.38682.Josef.Weidendorfer () gmx ! de
[Download RAW message or body]

On Wednesday 18 July 2007, Flavio Castelli wrote:
> Hi, I was adding BSD kqueue support to KDirWatch when, testing my patches, I 
> discovered bug #85989.
> I tried to fix it and I ended-up with these changes.

AFAICT the bug is about not supporting watchFiles and recursive flags in
KDirWatch::addDir(). But your changes do not touch this function?

The benefit of a separate thread would be to prohibit deadlock situations.
However, I am not really sure what your changes fix in this regard? Or
is this kind of a cleanup to prepare for future stuff?

> Talking about kqueue support, I've still some bugs to fix and some small 
> problems to solve.
> I'll commit this new feature as soon as possible. Changes regard only 
> KDirWatchPrivate and take place inside kdirwatch.cpp . Kqueue support will be 
> added in a way similar to inotify one. Since neither ABI nor API will be 
> broken I think the commit can be done also after API freeze. Am I wrong?

Yes.

Josef
[prev in list] [next in list] [prev in thread] [next in thread]