From kde-core-devel Fri Jul 13 12:10:59 2007 From: Ralf Habacker Date: Fri, 13 Jul 2007 12:10:59 +0000 To: kde-core-devel Subject: Re: AW: windows implementations of kshell and kuser Message-Id: <46976BD3.7010301 () freenet ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=118432869413069 Nhuh Put schrieb: > Hello > > Von: ralf.habacker@freenet. Gesendet: Dienstag, 10. Juli 2007 16:00 > Betreff: Re: windows implementations of kshell and kuser > >> Nhuh Put schrieb: >> >>> Hello >>> I've written implementations of kshell and kuser for windows: >>> http://mitglied.lycos.de/puthuhn/kshell_kuser.patch >>> I've removed some unused or rarely used functions from kshell. >>> >>> homeDir is duplicated in kuser, joinArgsDQ is unused and joinArgs( const >>> char * const *argv, int argc = -1) is only used in one place in kicker. >>> I could provide patchs to port away from those, and for the kshell >>> > unittest. > >>> Any suggestions or problems? >>> >>> >> Because this changes unix code and the public api also it should be send >> to kde-core-devel too. They should review and give an okay for the api >> changes before we can commit the windows related part. >> Are there any objectivites from the core gurus about the public api changes ? Otherwise I would apply this patch on monday. Ralf