[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: the importance of -ansi
From:       Thiago Macieira <thiago () kde ! org>
Date:       2007-06-15 23:30:24
Message-ID: 200706160130.37111.thiago () kde ! org
[Download RAW message or body]


Jos van den Oever wrote:
>2007/6/15, John Tapsell <johnflux@gmail.com>:
>> Wow, how on earth did you track that down?!
>>
>> I have much to learn from the demi-god coders.
>
>It was a mix of Thiago, valgrind, cpp and diff.

I thought it was a stale build because that had happened to me once. I was 
getting crashes I could not understand and valgrind was reporting memory 
violations ("address is 0 bytes after a block of XX bytes at 0xHHHHHH") 
that shouldn't be there. That's exactly the same symptom Jos was having.

My problem was fixed by removing all .o and rebuilding.

But when I started reading CLucene code, I was thinking "whoever released 
this should be sent back to school". Sorry, but the code is nasty. It 
changes class sizes according to macros like _DEBUG. That's just asking 
for trouble.

That is still my opinion. CLucene needs to be cleaned up so that it does 
NOT depend on macros.

In any case, I'd never have guessed math.h does the same thing. Then 
again, I'd never heard about float_t. Why is that being used at all? It's 
nowhere in glibc's TeXinfo documentation.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]