[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Color roles, coming this Monday to kdelibs?
From:       Olaf Schmidt <ojschmidt () kde ! org>
Date:       2007-06-15 18:38:01
Message-ID: 200706152038.02704.ojschmidt () kde ! org
[Download RAW message or body]

[ Matthew Woehlke, Do., 7. Jun. 2007 ]
> +    /**
>       * The default color to use when highlighting toolbar buttons.
>       * @return the toolbar highlight color
> +     * @deprecated use color(Button, bgHoverTint) instead
>       */
> -    static QColor toolBarHighlightColor();
> +    KDE_DEPRECATED static QColor toolBarHighlightColor();

Can we not simply kill this? It is only used in one single place according to 
lxr.kde.org (it used to be two places in KDE 3.5, but KToolBarButton has 
already died).

/koffice/libs/guiutils/KoTooluButton.cpp should either do what the normal 
ToolBarButton now does and not use this colour at all, or use
color(Button, fgFocusTint) as suggested in my mail from June 8, not 
bgHoverTint (which is a background colour).

Olaf

[prev in list] [next in list] [prev in thread] [next in thread]