[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] RFC: Changing the language of individual KDE programs
From:       "David Jarvie" <lists () astrojar ! org ! uk>
Date:       2007-05-21 16:35:17
Message-ID: 45196.S0VKQUNDQxA=.1179765317.squirrel () www ! sensical ! net
[Download RAW message or body]

On Monday 21 May 2007 10:11, Aaron J. Seigo wrote:
> On Monday 21 May 2007, David Jarvie wrote:
>> If the apidox comments are
>> improved, do you have any other objection to this class being moved to
>> kdelibs?
>
> well, yes. it's not the documentation, it's the fact that it's not
> language specific, though it's billed as being language specific. the
> insertLanguage
> method is completely superfluous as it doesn't load an icon even (that is
> commented out as being wrong).

Yes, there is very little language specific code in it.

> imho, what really ought to happen is one of two things:
>
> - the class is actually languageified and made into a truly language
> specific widget
> - the class is generified, including its name and documentation, and used
> for language use cases as one of its possible uses.
>
> i'd very much like to see the latter happen as other apps have need for
> such multi-column popups attached to a button.

AFAICS, it's actually only a single column popup. If so, I think that the
first option, to languagify it, is the way to go.

-- 
David Jarvie.
KAlarm author & maintainer.
http://www.astrojar.org.uk/kalarm

[prev in list] [next in list] [prev in thread] [next in thread]